1k-code-review-pr_skill

Overview

This skill provides a structured, actionable PR code review checklist tailored for the OneKey TypeScript monorepo. It focuses on detecting build failures, script problems, CI workflow gaps, documentation inconsistencies, and runtime risks. Reviews prioritize fixes with clear remediation steps and priority levels to speed safe merges.

How this skill works

Run a triple-dot diff against the base branch (origin/x...HEAD) and scan changed files for defined patterns: accidental files, build config references to generated assets, script exit behavior, CI verification gaps, hooks and concurrency issues, deprecated deps, error-handling gaps, and null/undefined risks. The skill produces concise findings with file references, a recommended fix snippet, key modification points, and a priority tag (High/Medium/Low). Use the provided grep/yq/npm checks and code patterns to reproduce and validate each issue.

When to use it

• When reviewing PRs that add or modify build scripts, electron configs, or asset generators
• When changes touch React hooks, async loops, or request logic that could cause runtime or performance regressions
• When CI workflows add generation steps or platform-specific jobs without verification
• When package.json changes introduce new dependencies or potential deprecations
• When PR description may not match scope of code changes (docs vs code drift)

Best practices

• Run git diff origin/x...HEAD with the provided checks to scope the review quickly
• Prioritize High items (build failures, hooks safety, null-safety, concurrent-request risks) and block merges until fixed
• Provide concrete code or shell snippets as fixes and list minimal test validations to confirm behavior
• Prefer non-destructive placeholders or file-existence checks in CI/scripts to avoid platform-dependent failures
• Recommend functional state updates, proper effect dependencies, and AbortController/cancellation for async effects

Example use cases

• A PR adds an electron extraResources entry referencing a generated file; detect and require placeholder or CI existence checks
• A shell script exits early when a tooling dependency is missing; suggest creating placeholder outputs before exit
• A component suppresses react-hooks/eslint and drops a dependency; report potential infinite loop or stale closure and propose corrected deps or refs
• A feature loops over many addresses with sequential await; recommend p-limit or batching to avoid backend overload
• A workflow step generates assets but lacks verification; add a verify step and fail-fast checks