code-review_skill

This skill performs structured code reviews to enforce six dimensions: service delegation, framework standards, ADR compliance, plan synchronization, and

Python

9

GitHub Stars

1

Bundled Files

2 months ago

Catalog Refreshed

4 months ago

First Indexed

Readme & install

Copy the install command, review bundled files from the catalogue, and read any extended description pulled from the listing source.

Installation

Preview and clipboard use veilstrat where the catalogue uses aiagentskills.

npx veilstrat add skill mhylle/claude-skills-collection --skill code-review

SKILL.md14.2 KB

Overview

This skill performs a systematic code review as a quality gate during implementation phases, verifying architectural principles, framework standards, ADR compliance, and overall code quality. It runs automatically as Step 3 of implement-phase or can be invoked manually to review PRs or local changes. The goal is to surface blocking issues early so phases finish with a clean baseline.

How this skill works

The skill inspects changed files, reads the plan and relevant ADRs, and applies a six-dimension checklist: service delegation, framework standards, ADR compliance, plan synchronization, general code quality, and coding standards. It compares code against discovered project patterns and configured standards, aggregates findings, and returns a structured verdict (PASS | PASS_WITH_NOTES | NEEDS_CHANGES). When blocking issues are found, it lists required fixes and supports retry logic until the review passes or retry limits are reached.

When to use it

Automatically after each implement-phase functional verification before marking phase complete
Manually when reviewing a pull request or set of code changes
Before committing large or sensitive changes to ensure ADR and standards compliance
When plan or exit conditions must be synchronized with implementation
When verifying that changes didn’t introduce build, lint, type, or test failures

Best practices

Read the implementation plan and relevant ADRs before reviewing code
Prioritize and report blocking issues first; be specific about file and line locations
Verify fixes by re-running the review rather than assuming they are resolved
Treat any build/lint/type/test failures as blocking—fixes must be included in the phase
Document new architectural decisions as ADRs and link them in the plan

Example use cases

Automatic review of Phase 2 Authentication changes and return structured PASS_WITH_NOTES report
Manual invocation on a PR: focus review on service delegation and framework patterns
Run as part of CI gating to block merges that introduce security or type regressions
Review plan synchronization after implementation to ensure tasks and exit conditions are updated
Run follow-up reviews after automated fixes are applied to confirm resolution

FAQ

Blocking issues include security vulnerabilities, hardcoded secrets, ADR violations, missing tests for new functionality, and any build/lint/type/test failures in any file.

Does the review consider unchanged files?

Yes. Any errors in unchanged files are treated as the current phase's responsibility because the pipeline assumes a clean baseline before the phase began.