rfc-check_skill

Overview

This skill evaluates proposed code changes and determines whether a Request for Comments (RFC) is required before implementation. It is tailored for the openenv project and focuses on API, architectural, and pattern-level changes that affect maintainers and integrators. Use it to get a clear verdict and next steps when planning significant work.

How this skill works

The skill inspects the list of changed files and highlights any touches to core area files (src/openenv/core/). It checks for public API signature changes, new abstractions or design patterns, and interactions with the two-interface model (WebSocket/MCP). It also cross-references existing RFCs in rfcs/ to find conflicts or dependencies and then returns a concise verdict and recommended actions.

When to use it

• Before starting work that may add or change public APIs
• When proposing new architectural or design patterns
• When changes touch src/openenv/core/
• When modifying the WebSocket/MCP separation or related interfaces
• When unsure whether changes introduce breaking behavior

Best practices

• Run git diff --name-only to capture all changed files before analysis
• Focus on public API signatures and exported behaviors, not only internal refactors
• Cross-check rfcs/ for preexisting decisions to avoid duplication
• Document design goals and migration paths when an RFC is recommended
• Keep change descriptions concise and include usage examples for API changes

Example use cases

• Adding a new client-facing module under src/openenv/core/ that other packages will import
• Altering function signatures or class constructors used by external code
• Introducing a new communication pattern that mixes WebSocket and MCP responsibilities
• Refactoring internals for performance without changing public APIs (likely NOT requiring an RFC)
• Updating examples, tests, docs, or dependencies (NOT requiring an RFC)