meta-pytorch/openenv

Overview

This skill validates code changes before submitting a pull request by running automated hooks, alignment reviews, RFC checks, and documentation freshness checks. It produces a structured Pre-Submit PR Report that highlights blocking issues, discussion points, and an overall verdict. Use it to avoid common PR rework and to make review actionable and focused.

How this skill works

The skill runs the repository's automated hooks for linting, tests, and debug detection, then inspects changed files against project principles and invariants. It flags Tier 1 (blocking mechanical) and Tier 2 (alignment/discussion) issues, checks whether an RFC is required for API or core changes, and verifies REPO_WALKTHROUGH.md reflects structural changes. Finally, it summarizes blocking items, reviewer discussion points, and a concise verdict suitable for the PR description.

When to use it

• Before creating or updating a pull request
• When someone asks “is this ready for review?”
• Before pushing changes intended for a PR
• When touching core modules (src/openenv/core/)
• After refactoring public APIs or moving files

Best practices

• Run all automated hooks locally before invoking the skill to reduce false negatives
• Address all Tier 1 items (lint, tests, debug statements) before PR submission
• If public APIs or core files change, draft an RFC or mark RFC required in the report
• Update REPO_WALKTHROUGH.md along with structural changes and include the update in the PR
• Include the generated Pre-Submit PR Report verbatim in the PR description for reviewer context

Example use cases

• A developer refactors an environment API and wants to confirm an RFC is needed and tests pass
• A contributor adds a new environment directory and needs to update the repo walkthrough and confirm documentation changes are included
• A maintainer runs a pre-push check to catch debug statements and lint failures before opening a PR
• A reviewer wants a concise checklist of blocking issues and discussion points included in the PR description