code-review-preferences_skill

This skill helps review code, PRs, and standards by applying a 3-pass method to improve correctness, readability, and maintainability.

1

GitHub Stars

1

Bundled Files

2 months ago

Catalog Refreshed

4 months ago

First Indexed

Readme & install

Copy the install command, review bundled files from the catalogue, and read any extended description pulled from the listing source.

Installation

Preview and clipboard use veilstrat where the catalogue uses aiagentskills.

npx veilstrat add skill chaiwithjai/claude-code-mastery --skill code-review-preferences

SKILL.md1.8 KB

Overview

This skill provides a practical, team-focused code review preference and workflow to apply when reviewing code, PRs, or discussing code quality standards. It codifies a three-pass review method, a prioritized checklist, and a feedback style that keeps reviews constructive and efficient. Use it to catch bugs, share knowledge, and maintain consistency without blocking progress or enforcing personal style preferences.

How this skill works

Begin by selecting the intake method: paste a diff, reference files, or describe the PR and context. Perform the three-pass method: first understand scope, then verify correctness and edge cases, and finally suggest improvements with a strict limit on comments. Use the must/should/nice-to-check checklist to guide the review, and follow the feedback style rules to keep comments actionable and respectful.

When to use it

Reviewing a pull request for a bug fix, feature, or refactor
Performing pre-merge checks to prevent production bugs
Onboarding teammates to consistent code quality standards
Code-review training sessions or pair reviews
Auditing security-sensitive changes or secret leaks

Best practices

Start with Pass 1: understand scope and affected files before commenting
Prioritize correctness and security checks before style or performance
Limit actionable comments to a maximum of five per review
Ask clarifying questions and be specific about line numbers and suggestions
Acknowledge good work and avoid dictating personal style choices

Example use cases

A reviewer pastes a diff for a new endpoint and runs the three-pass method to find an unhandled edge case
A team uses the checklist on every PR to ensure tests pass and no secrets are introduced
A senior engineer mentors a junior via inline comments that follow the feedback style rules
A security-focused review prioritizes vulnerability and secret checks from the must-check list
A performance refactor review includes 'nice to check' items like benchmarks and pattern consistency

FAQ

Keep reviews focused: aim for no more than five substantive comments in the improvements pass; use passes one and two to find critical issues without over-commenting.

What if I disagree on style?

Avoid imposing personal style. Suggest style changes only if they affect readability or consistency and reference team conventions or formatting tools.