makefile-validator_skill

Overview

This skill validates, lints, and optimizes Makefiles (Makefile, makefile, *.mk) to ensure reliable, secure, and well-formatted build configurations. It combines GNU make syntax checks, the mbake formatter/linter, and custom rules for security and best practices. Use it to catch syntax errors, enforce formatting, and surface performance or safety issues before they hit CI or production.

How this skill works

The validator runs a layered pipeline: dependency checks, a dry-run GNU make syntax validation, mbake validation/format checks, and custom pattern checks for security and best practices. It creates a temporary isolated Python venv, installs mbake, runs automated checks, generates a color-coded report with errors/warnings/info, and cleans up the venv on exit. The tool reports line numbers, suggested fixes, and commands to apply automatic formatting.

When to use it

• Pre-commit or CI validation of Makefiles and *.mk files
• Code reviews to enforce .PHONY, tab usage, and dependency correctness
• Security audits to find hardcoded credentials or unsafe command expansions
• Refactoring legacy Makefiles or converting to modern patterns
• Performance tuning to discover unnecessary recompilation or parallelization issues

Best practices

• Declare .PHONY for non-file targets to avoid conflicts with filesystem names
• Use TAB characters for recipe lines; mbake will detect and fix spacing issues
• Prefer := for immediate variable evaluation when appropriate to avoid recursion
• Add error handling in recipes (set -e, ||) and avoid unquoted variable use in shell commands
• Run the validator in pre-commit hooks and CI to catch regressions early

Example use cases

• Run validate_makefile.sh Makefile in a pre-commit hook to block commits with errors
• Use mbake format --diff Makefile to preview and apply formatting fixes
• Scan build recipes for unsafe commands like unquoted rm/curl/wget and hardcoded tokens
• Audit a legacy Makefile: fix tabs/syntax, add .PHONY, then re-run validation
• Integrate the validator into GitHub Actions to validate all Makefiles on PRs